New option for simplemodal #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Nicholas. I'm not sure that there are enough situations to warrant this change - do you have a use case? |
|
My use case was for Hackruiter.com. If you press ? on the frontpage, you'll get a modal dialog with keyboard shortcuts, and I wanted any key press to close the help window. In general, I think any time you want to have modal display of info/help but make it hard for the user to get caught in it, having any key to close is useful. I've definitely seen other sites that have used this behavior on, but I can't think of them off the top of my head. Best, |
|
Closing, out dated and as @ericmmartin stated, there aren't enough use cases for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to allow any keypress to close my dialog, so I added a new option (anykeyClose, false by default) to simplemodal.
Thanks for an awesome library! It's just what I was looking for and only took a minute to get working.
Best,
-Nick